[PATCH] D118754: [DebugInfo] Always emit `.debug_names` with dwarf 5 for Apple platforms

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 16:11:24 PDT 2023


JDevlieghere updated this revision to Diff 530697.
JDevlieghere marked an inline comment as done.
JDevlieghere added a comment.
Herald added a subscriber: ormris.

Address @probinson's feedback:

- Don't reuse existing value so we don't change the meaning of old bitcode input.
- Add more tests


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118754/new/

https://reviews.llvm.org/D118754

Files:
  clang/lib/CodeGen/CGDebugInfo.cpp
  clang/test/CodeGen/debug-info-names.c
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/lib/AsmParser/LLLexer.cpp
  llvm/lib/CodeGen/AsmPrinter/AccelTable.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/test/DebugInfo/Inputs/name-table-kind-apple-4.ll
  llvm/test/DebugInfo/Inputs/name-table-kind-apple-5.ll
  llvm/test/DebugInfo/accel-tables-apple.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D118754.530697.patch
Type: text/x-patch
Size: 12031 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230612/1a080b51/attachment.bin>


More information about the llvm-commits mailing list