[PATCH] D152730: [ConstraintElim] Add A < B if A is an increasing phi for A != B.

Antonio Frighetto via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 13:45:22 PDT 2023


antoniofrighetto added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/ConstraintElimination.cpp:1149
+    auto *N = DT.getNode(Succ);
+    if (NumIn == N->getDFSNumIn() && NumOut == N->getDFSNumOut()) {
+      InLoopSucc = Succ;
----------------
Very minor, but one may find this slightly more readable?
```
  if (NumIn == N->getDFSNumIn() && NumOut == N->getDFSNumOut())
    InLoopSucc = Succ;
  else
    LoopExitSucc = Succ;
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152730/new/

https://reviews.llvm.org/D152730



More information about the llvm-commits mailing list