[PATCH] D152672: [InstCombine] Add tests for canonicalizing `(X^(X-1)) u{ge,lt} X` as pow2 test; NFC

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 11:59:01 PDT 2023


nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/test/Transforms/InstCombine/ispow2.ll:1213
+  ret i1 %r
+}
----------------
I'd add two more negative tests where the operands in and/xor and xor/icmp are not the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152672/new/

https://reviews.llvm.org/D152672



More information about the llvm-commits mailing list