[PATCH] D152357: MachineConstantPool::getConstantPoolIndex - don't reuse mismatched constants contained undef/poison (Issue #63108)
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 12 11:57:39 PDT 2023
efriedma added a comment.
Maybe worth intentionally noting that it's fine if B contains undef because if the check succeeds, we completely discard the constant B (so its contents don't matter).
It's a little weird that it's asymmetric like that, but I don't imagine it causes any immediate issue. (Merging constant pools isn't really that important at this level anyway because the linker also merges constant pools.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152357/new/
https://reviews.llvm.org/D152357
More information about the llvm-commits
mailing list