[PATCH] D152308: [RISCV] Prevent overflowing the small size of InstSeq in generateInstSeq.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

In D152308#4414826 <https://reviews.llvm.org/D152308#4414826>, @asb wrote:

> Sorry for the slow review, I was mostly out / traveling last week.
>
> The original logic was written to be dumb but easy to follow, and in the absence of benchmarking data I'd be tempted to just bump the size to keep the logic that way. But this change seems correct and I've got not real objection to it if it's your preferred approach.

I'm not sure how to enforce the small size is sufficient if we do go that way. I was wondering if this sequence was a good candidate for the StaticVector proposed in https://reviews.llvm.org/D112175. I tried to make InstSeq into my own simplified static vector with a buffer of 8 and that's how I found the overflow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152308/new/

https://reviews.llvm.org/D152308