[PATCH] D152701: LowerMemIntrinsics: Check address space aliasing for memmove expansion

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM in principle.



================
Comment at: llvm/lib/Transforms/Utils/LowerMemIntrinsics.cpp:401-410
+          /* InsertBefore */ InsertBefore,
+          /* SrcAddr */ SrcAddr,
+          /* DstAddr */ DstAddr,
+          /* CopyLen */ CI,
+          /* SrcAlign */ SrcAlign,
+          /* DestAlign */ DstAlign,
+          /* SrcIsVolatile */ SrcIsVolatile,
----------------
Nit: The comments matching the variable names don't look particularly useful. I'd remove most of leam, maybe leaving the `CanOverlap`. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152701/new/

https://reviews.llvm.org/D152701