[PATCH] D152700: TargetTransformInfo: Add addrspacesMayAlias
Artem Belevich via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 12 11:05:21 PDT 2023
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.h:461-462
+
+#define ASMay true
+#define ASNo false
+ // This array is indexed by address space value enum elements 0 ... to 8
----------------
Nit: Now that we don't need to use `AliasResult::MayAlias/NoAlias` I do not see these macros improving readability over the plain true/false.
If you do prefer to use ASMay/ASNo, just make them `const bool`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152700/new/
https://reviews.llvm.org/D152700
More information about the llvm-commits
mailing list