[PATCH] D76354: [RISCV][GlobalISel] Legalize types for ALU operations

Nitin John Raj via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 10:45:17 PDT 2023


nitinjohnraj planned changes to this revision.
nitinjohnraj marked 2 inline comments as done.
nitinjohnraj added a comment.

We do not plan on handling w-instructions for globalisel at -O0. For legalization without w-instructions, see D152726 <https://reviews.llvm.org/D152726>.



================
Comment at: llvm/lib/Target/RISCV/GISel/RISCVLegalizerInfo.cpp:75-76
+
+    getActionDefinitionsBuilder(G_UMULH).legalFor({XLenLLT}).clampScalar(
+        0, XLenLLT, XLenLLT);
+  }
----------------
arsenm wrote:
> I think this is a really ugly way to wrap legalize rules and clang-format is wrong
I completely agree. Should I manually format this part?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76354/new/

https://reviews.llvm.org/D76354



More information about the llvm-commits mailing list