[PATCH] D152684: [ConstraintElimination] Handle solving-only non-equality predicates

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/ConstraintElimination.cpp:593
     // In order to check that `%a == %b` is true, we want to check that `%a >=
     // %b` and `%a <= %b` must hold.
     if (IsConditionImplied && IsNegatedOrEqualImplied)
----------------
might be good to expand the comment here, explaining how this handles `==` and `!=`. Same below.


================
Comment at: llvm/test/Transforms/ConstraintElimination/assumes.ll:626
+
+define i1 @assume_1(i64 %a, i64 %b) {
+; CHECK-LABEL: @assume_1(
----------------
better move those to `ne.ll` and also add variants with `ule`/`uge`. Would be good to add the tests separately.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152684/new/

https://reviews.llvm.org/D152684