[PATCH] D152619: [CMake] Fixes using CMake 3.27.0.

Mon Jun 12 08:28:14 PDT 2023

Mordante added a comment.

In D152619#4413892 <https://reviews.llvm.org/D152619#4413892>, @kwk wrote:

> In D152619#4413601 <https://reviews.llvm.org/D152619#4413601>, @Mordante wrote:
>
>> In D152619#4413263 <https://reviews.llvm.org/D152619#4413263>, @kwk wrote:
>>
>>> Can you please how things fail? What is the error message for example?
>>
>> Good point! I updated the commit message.
>
> Thank you.
>
> Can I assume that the follow-up error after adding `include(CheckCSourceCompiles)` is similar but with `CHECK_CXX_SOURCE_COMPILES`?
>
> Could this be an error in CMake itself that should be fixed upstream?

Based on the documentation https://cmake.org/cmake/help/latest/module/CheckCSourceCompiles.html this module provides `CHECK_C_SOURCE_COMPILES`. So I think we forgot an include and it just happened to work.

I expect this https://github.com/Kitware/CMake/commit/03c6ebf2b53956d9d8d035f9bf67bb73caca65f3 caused the issue
`CheckCCompilerFlag.cmake` removed its `CheckCSourceCompiles` include.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152619/new/

https://reviews.llvm.org/D152619