[PATCH] D152421: [RISCV] Introduce the concept of DLEN(data path width) into getLMULCost.

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 07:54:22 PDT 2023


asb added a comment.

LGTM after you add a doc comment to getDLenFactor.



================
Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:182
 
+  unsigned getDLenFactor() const {
+    if (DLenFactor2)
----------------
I think we need a comment here to explain the purpose of the method.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152421/new/

https://reviews.llvm.org/D152421



More information about the llvm-commits mailing list