[PATCH] D152691: [LICM] Sunk instructions with invalid source location.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 07:30:05 PDT 2023


aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:1715
         PN, &I, LI, SunkCopies, SafetyInfo, CurLoop, MSSAU);
+    New->dropLocation();
     PN->replaceAllUsesWith(New);
----------------
Can you add a comment here explaining that we do this because we sink the instruction out of the BB?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152691/new/

https://reviews.llvm.org/D152691



More information about the llvm-commits mailing list