[PATCH] D152095: DWARFVerifier: Verifies that definition subprograms cannot be nested within structures such as classes and structs

[DianQK via Phabricator via llvm-commits]

DianQK updated this revision to Diff 530498.
DianQK added a comment.

What I would like to ask is about the checks related to inlined subroutines in the issue. How are they different from the checks for definition subprograms? Based on your previous explanation and my current understanding, it seems that checking `DISubprogram` should be sufficient.

> In the current context, I think I can understand that "subroutine" and "subprogram" are the same term/semantics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152095/new/

https://reviews.llvm.org/D152095

Files:
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp
  llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h
  llvm/lib/IR/Verifier.cpp
  llvm/test/DebugInfo/Generic/cross-cu-inlining-2.ll
  llvm/test/DebugInfo/Generic/cross-cu-inlining-ranges.ll
  llvm/test/Verifier/disubprogram-declaration-within-struct.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152095.530498.patch
Type: text/x-patch
Size: 13512 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230612/befda061/attachment.bin>