[PATCH] D141712: [GVN] Improve PRE on load instructions

Mon Jun 12 06:02:58 PDT 2023

uabelho added a comment.

Hi,

The following starts crashing with this patch:

  opt -passes="inline,function<eager-inv;no-rerun>(gvn<>)" bbi-83499.ll -o /dev/null -debug

It requires -debug to crash since there is a verifyRemoved call hidden in a LLVM_DEBUG.

F27900063: bbi-83499.ll <https://reviews.llvm.org/F27900063>

================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:3126
+    MSSAU->removeMemoryAccess(I);
+  LLVM_DEBUG(verifyRemoved(I));
+  ICF->removeInstruction(I);
----------------
A bit strange to hide verification in LLVM_DEBUG? So we only run that with debug printouts turned on?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D141712/new/

https://reviews.llvm.org/D141712