[PATCH] D152213: ShrinkWrap: Ignore load/store until stack address computation

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 05:42:44 PDT 2023


qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

Hi @MatzeB

The change looks good to me, but can we flip the logic `NoStackAddressUsed` => `StackAddressUsed`?

I find the `!Noxxx` or `Noxxx = false` difficult to reason about :).

Cheers,
-Quentin


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152213/new/

https://reviews.llvm.org/D152213



More information about the llvm-commits mailing list