[PATCH] D152659: [LV] Add IRBuilder folder to simplify GEP x, 0.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 03:57:50 PDT 2023


fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:480
+/// Folder to simplify common patterns generated by LV codegen.
+class LVFolder final : public ConstantFolder {
+  void anchor() override {}
----------------
nikic wrote:
> Any reason to base this on ConstantFolder rather than TargetFolder?
No particular reason, it could definitely also be TargetFolder. In general, I think those sort of lightweight simplifications could be beneficial for most/all users of `ConstantFolder/TargetFolder`, so it might make sense to also use them there eventually?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152659/new/

https://reviews.llvm.org/D152659



More information about the llvm-commits mailing list