[PATCH] D140528: [msan] Add msan support for loongarch64

Mon Jun 12 02:55:59 PDT 2023

Ami-zhang added inline comments.

================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:437
     0x0B00000000000, // XorMask
     0,               // ShadowBase (not used)
     0x0200000000000, // OriginBase
----------------
vitalybuka wrote:
> can  you please move this file into a separate patch and add some tests
> 
> e.g. autogenerated like this:
> llvm/utils/update_test_checks.py --opt-binary ../out/bin/opt llvm-project/llvm/test/Instrumentation/MemorySanitizer/AArch64/vararg.ll --check-globals 
> 
Ok, I have moved it into another patch.

Without LLVM part of the LoongArch memory sanitizer implementation, there are many failing tests with `"error in backend: unsupported architecture"` in check-msan. And with that implementation, the tests all pass.

Currently,  `VarArgHelper` implementation on LoongArch isn't supported yet, which will be done separately later. But we will add a test for VarArgNoOpHelper in llvm/test/Instrumentation/MemorySanitizer/LoongArch, which is based on the X86 one.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140528/new/

https://reviews.llvm.org/D140528