[PATCH] D152313: [RISCV] Remove RISCVII::hasMergeOp. NFC

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 12 02:06:16 PDT 2023


frasercrmck added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVMCInstLower.cpp:176
+    // operand after the result.
+    if (OpNo == MI->getNumExplicitDefs() &&
+        MCID.getOperandConstraint(OpNo, MCOI::TIED_TO) == 0) {
----------------
I notice that code checks `getNumExplicitDefs` but `isFirstDefTiedToFirstUse` checks jut `getNumDefs` - is this significant? The number of "explicit" defs seems more correct to me.

If that were fixed up, could this code use `isFirstDefTiedToFirstUse`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152313/new/

https://reviews.llvm.org/D152313



More information about the llvm-commits mailing list