[PATCH] D143637: StackProtector: add unwind cleanup paths for instrumentation.

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added subscribers: nickdesaulniers, jyknight.
smeenai added a comment.

There's actually a valid reason to build libunwind with `-fexceptions`, which is getting functions like `_Unwind_Resume` to not be marked `nounwind`, which would otherwise cause invalid LSDA to be generated when you LTO libunwind together with other libraries. See https://github.com/llvm/llvm-project/issues/56825 and @jyknight's comment on it.

When we reland this, would there be any way to account for the `-disable-check-noreturn-call` flag added in D141556 <https://reviews.llvm.org/D141556>, to avoid the size increase for people who don't want to pay it? CC @nickdesaulniers, who also had size concerns that motivated D147975 <https://reviews.llvm.org/D147975>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143637/new/

https://reviews.llvm.org/D143637