[PATCH] D143637: StackProtector: add unwind cleanup paths for instrumentation.

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

> So I think the Chromium test needs updating in this case (though I don't really know what it was trying to do so I'm not sure how). @hans, what do you think? Is that feasible? Do you disagree with the reasoning?

I'm certainly not an expert on ObjC lifetime management. Based on the original test (quoted in https://bugs.chromium.org/p/chromium/issues/detail?id=1428624#c4) it sounds like it's already sensitive to when exactly things get released. So if we're confident that the new behavior is also correct, I suppose the test should be updated.

But, I also notice that my reproducer works with `-fno-exceptions`, which is surprising to me. Why is this change also affecting `-fno-exceptions` code?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143637/new/

https://reviews.llvm.org/D143637