[PATCH] D152501: [GlobalIsel][X86] Legalize G_FREEZE

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/X86/X86LegalizerInfo.cpp:319
 
+  // copy
+  getActionDefinitionsBuilder(G_FREEZE)
----------------
RKSimon wrote:
> copy -> freeze?
Don't see the point of the comment if it just restates freeze. For those who don't know freeze, something stating it's just a copy kind of makes sense


================
Comment at: llvm/lib/Target/X86/X86LegalizerInfo.cpp:324
+    .clampScalar(0, s8, sMaxScalar)
+    .widenScalarToNextPow2(1, /*Min=*/8)
+    .clampScalar(1, s8, sMaxScalar);
----------------
RKSimon wrote:
> Why do you need the second type idx?
freeze only has one


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152501/new/

https://reviews.llvm.org/D152501