[PATCH] D152501: [GlobalIsel][X86] Legalize G_FREEZE

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Target/X86/X86LegalizerInfo.cpp:319
 
+  // copy
+  getActionDefinitionsBuilder(G_FREEZE)
----------------
copy -> freeze?


================
Comment at: llvm/lib/Target/X86/X86LegalizerInfo.cpp:324
+    .clampScalar(0, s8, sMaxScalar)
+    .widenScalarToNextPow2(1, /*Min=*/8)
+    .clampScalar(1, s8, sMaxScalar);
----------------
Why do you need the second type idx?


================
Comment at: llvm/test/CodeGen/X86/GlobalISel/legalize-freeze.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 2
+# RUN: llc -verify-machineinstrs -mtriple=x86_64-linux-gnu -run-pass=legalizer %s -o - | FileCheck %s
+
----------------
Add 32-bit test coverage as well


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152501/new/

https://reviews.llvm.org/D152501