[PATCH] D152453: llvm-cov produces inconsistent result when file appears multiple times in gcno

[Justin Bogner via Phabricator via llvm-commits]

bogner added inline comments.


================
Comment at: llvm/lib/ProfileData/GCOV.cpp:146
+      SmallString<256> P;
+      P.assign(filename);
+      sys::path::remove_dots(P, true);
----------------
Why not `SmallString<256> P(filename)`?

Regardless, it might help readability to add a function named something like "addNormalizedPathToMap" that does this and calls emplace as below rather than doing this all inline here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152453/new/

https://reviews.llvm.org/D152453