[PATCH] D152414: AMDGPU: Do not not force alwaysinline with calls and module LDS enabled

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 16:27:32 PDT 2023


arsenm added a comment.

In D152414#4406423 <https://reviews.llvm.org/D152414#4406423>, @scchan wrote:

> hipcc uses this switch because the enablement of alwaysinline requires that the function call support be turned off why do we have to turn off function call?

I'm still confused about what you're asking. Function calls are supposed to always be on, they can't actually be completely avoided. amdgpu-function-calls was for bringup of call support and should be retired. This maintains the flag for the force off usage hipcc was relying on, for now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152414/new/

https://reviews.llvm.org/D152414



More information about the llvm-commits mailing list