[PATCH] D152414: AMDGPU: Do not not force alwaysinline with calls and module LDS enabled
Siu Chi Chan via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 8 11:11:31 PDT 2023
scchan added a comment.
In D152414#4406186 <https://reviews.llvm.org/D152414#4406186>, @arsenm wrote:
> In D152414#4406127 <https://reviews.llvm.org/D152414#4406127>, @scchan wrote:
>
>>> We should probably drop the amdgpu-function-calls too but I think
>>> hipcc is still using it.
>>
>> The `amdgpu-function-calls` switch is needed to disable function calls as a prereq to enable alwaysinline, which I don't understand why.
>
> I'm failing to parse this sentence
hipcc uses this switch because the enablement of alwaysinline requires that the function call support be turned off why do we have to turn off function call?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152414/new/
https://reviews.llvm.org/D152414
More information about the llvm-commits
mailing list