[PATCH] D151511: [CMake] Enable building with UBSAN + clang-cl on windows

Thu Jun 8 10:17:38 PDT 2023

dwang added inline comments.

================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:968
+      endif()
+      append("-D_ITERATOR_DEBUG_LEVEL=0" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
+      append(${LLVM_UBSAN_FLAGS} CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
----------------
pgousseau wrote:
> Could we add a succint comment to explain -D_ITERATOR_DEBUG_LEVEL=0 ? Is it for performance or to workaround a bug?
This was a workaround for debug level mismatch between UBSAN runtime and another module. Somehow the bug does not reproduce on latest master branch anymore. I will remove this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151511/new/

https://reviews.llvm.org/D151511