[PATCH] D151511: [CMake] Enable building with UBSAN + clang-cl on windows

pierre gousseau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 03:17:17 PDT 2023


pgousseau added inline comments.


================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:968
+      endif()
+      append("-D_ITERATOR_DEBUG_LEVEL=0" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
+      append(${LLVM_UBSAN_FLAGS} CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
----------------
Could we add a succint comment to explain -D_ITERATOR_DEBUG_LEVEL=0 ? Is it for performance or to workaround a bug?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151511/new/

https://reviews.llvm.org/D151511



More information about the llvm-commits mailing list