[PATCH] D152437: PowerPC/SPE: Add phony registers for high halves of SPE SuperRegs
Justin Hibbits via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 8 07:16:35 PDT 2023
jhibbits added a comment.
I love the goal of this, but it looks incomplete. I only noted on one, but it's probably the same for the other tests, that the change will end up clobbering the top half of registers without saving and restoring them.
================
Comment at: llvm/test/CodeGen/PowerPC/fp-strict.ll:1609
+; SPE-NEXT: evldd r11, 56(r1)
+; SPE-NEXT: stw r26, 8(r1) # 4-byte Folded Spill
+; SPE-NEXT: stw r27, 12(r1) # 4-byte Folded Spill
----------------
This is wrong, because below it's `evmergelo`ing into these registers, which clobbers the top half.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152437/new/
https://reviews.llvm.org/D152437
More information about the llvm-commits
mailing list