[PATCH] D151747: [llvm-jd] introduces a new tool for diffing JSON

[Aaron Ballman via Phabricator via llvm-commits]

aaron.ballman added inline comments.


================
Comment at: llvm/utils/llvm-jd/llvm-jd.cpp:86-88
+  if (Result) {
+    return *std::move(Result);
+  }
----------------
cjdb wrote:
> aaron.ballman wrote:
> > I'll stop commenting on style issues; you should take a pass through to make sure things match our usual style guidelines.
> I was hoping that we could add braces since this is a new tool. Naming, on the other hand, is just negligence and shall be corrected.
New code should continue to follow our usual developer policies instead of forging a new path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151747/new/

https://reviews.llvm.org/D151747