[PATCH] D151747: [llvm-jd] introduces a new tool for diffing JSON

[Jon Roelofs via Phabricator via llvm-commits]

jroelofs added inline comments.


================
Comment at: llvm/utils/llvm-jd/llvm-jd.cpp:429
+  return not D.empty();
+}
----------------
cjdb wrote:
> jroelofs wrote:
> > missing trailing newline
> There is a trailing newline: Phab just doesn't show it. (It'll tell you that there's a missing new line, and I have VS Code set up to ensure that there's always exactly one new line at the end of the file.)
> 
> Unless you're saying there should be two?
nvm, you're right, and looks like that restriction went away in C++11... carry on ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151747/new/

https://reviews.llvm.org/D151747