[PATCH] D152370: [Intrinsic] Introduce reduction intrinsics for minimum/maximum

Wed Jun 7 08:33:21 PDT 2023

nikic added a comment.

I'm fine with this addition, but...

> We do not introduce a new SelectionDAG node for this, since we support
> the lowering for these intrinsics by transforming them into a series of
> shuffle and use the vectorized versions of llvm.minimum and
> llvm.maximum (D152371 <https://reviews.llvm.org/D152371>).

You do need to add VECREDUCE nodes for this. The ExpandReductions pass is considered legacy functionality, mostly for use by X86. Targets like AArch64 do not use it and rely on VECREDUCE legalization instead.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152370/new/

https://reviews.llvm.org/D152370