[PATCH] D151996: [AMDGPU] Start documenting calling conventions. NFC

Wed Jun 7 05:59:33 PDT 2023

rovka added a comment.

In D151996#4400527 <https://reviews.llvm.org/D151996#4400527>, @scott.linder wrote:

> Can you reupload with full context? If you're using the web interface I think https://www.llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface is still accurate, so something like:
>
>   git show HEAD -U999999 > mypatch.patch

Sorry, I haven't used the web interface in a while so I forgot that part... Anyway, I got arc working again now, so it shouldn't happen again in the future.

> I ask because I think this should be cross-referenced with (or maybe even combined with) the existing `Call Convention` docs around line ~13500:
>
>   Call Convention
>   ~~~~~~~~~~~~~~~
>   
>   .. note::
>   
>     This section is currently incomplete and has inaccuracies. It is WIP that will
>     be updated as information is determined.
>   
>   See :ref:`amdgpu-dwarf-address-space-identifier` for information on swizzled
>   addresses. Unswizzled addresses are normal linear addresses.
>   
>   .. _amdgpu-amdhsa-function-call-convention-kernel-functions:
>   
>   Kernel Functions
>   ++++++++++++++++
>   
>   This section describes the call convention ABI for the outer kernel function.
>   ...

I added a :ref: to this from ``amdgpu_kernel``. There should probably be a reference to `amdgpu-amdhsa-function-call-convention-non-kernel-functions` somewhere but I'm not sure where. Is this actually the `ccc`?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151996/new/

https://reviews.llvm.org/D151996