[PATCH] D151996: [AMDGPU] Start documenting calling conventions. NFC

Wed Jun 7 05:32:42 PDT 2023

rovka marked 3 inline comments as done.
rovka added inline comments.

================
Comment at: llvm/docs/AMDGPUUsage.rst:1048
+     =============================== ==========================================================
+     Calling Convention              Description
+     =============================== ==========================================================
----------------
scchan wrote:
> Nit: this list seems to be in a random order, can we sort this in alphabetical order or organize it in a more meaningful way? 
Ok, I alphabetized it for now, except for the `ccc` which looks good at the top imo. I'm open to other suggestions.

================
Comment at: llvm/docs/AMDGPUUsage.rst:1084
+
+     ``amdgpu_gfx``                  Used for AMD graphics targets.
+                                     ..TODO::
----------------
arsenm wrote:
> "graphics targets?" Doesn't really say how it's not an entry point 
> "graphics targets?" 

...apparently :) I just copied the comments from [[ https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/IR/CallingConv.h#L228 | the enum ]], I have no idea what this is used for (one of the reasons why I thought we should start writing these things up in more detail). 

> Doesn't really say how it's not an entry point 

I mentioned that now. Ideally we'd describe it more thoroughly in a follow-up patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151996/new/

https://reviews.llvm.org/D151996