[PATCH] D151511: [CMake] Enable building with UBSAN + clang-cl on windows

Duo Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 6 16:31:39 PDT 2023


dwang updated this revision to Diff 529085.
dwang added a comment.

fix error message & newline at end of file


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151511/new/

https://reviews.llvm.org/D151511

Files:
  llvm/cmake/modules/HandleLLVMOptions.cmake
  llvm/utils/sanitizers/ubsan_ignorelist.txt


Index: llvm/utils/sanitizers/ubsan_ignorelist.txt
===================================================================
--- llvm/utils/sanitizers/ubsan_ignorelist.txt
+++ llvm/utils/sanitizers/ubsan_ignorelist.txt
@@ -20,4 +20,4 @@
 src:*/ADT/StringMap.h
 src:*/Support/AllocatorBase.h
 src:*/ADT/StringMapEntry.h
-src:*/ADT/SmallPtrSet.h
\ No newline at end of file
+src:*/ADT/SmallPtrSet.h
Index: llvm/cmake/modules/HandleLLVMOptions.cmake
===================================================================
--- llvm/cmake/modules/HandleLLVMOptions.cmake
+++ llvm/cmake/modules/HandleLLVMOptions.cmake
@@ -963,7 +963,7 @@
     endif()
     if (LLVM_USE_SANITIZER MATCHES ".*Undefined.*") 
       if (NOT CLANG_CL)
-        message(FATAL_ERROR "This sanitizer only supported in the clang-cl: Undefined")
+        message(FATAL_ERROR "This sanitizer is only supported by clang-cl: Undefined")
       endif()
       append("-D_ITERATOR_DEBUG_LEVEL=0" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
       append(${LLVM_UBSAN_FLAGS} CMAKE_C_FLAGS CMAKE_CXX_FLAGS)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151511.529085.patch
Type: text/x-patch
Size: 1044 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230606/38e3c822/attachment.bin>


More information about the llvm-commits mailing list