[PATCH] D151511: [CMake] Enable building with UBSAN + clang-cl on windows

Tue Jun 6 09:55:54 PDT 2023

andrewng added a comment.

Apart from the two nits, the CMake changes LGTM, although I haven't tested the patch myself. I'm not particularly familiar with UBSAN, so can't really comment on the other changes to `ubsan_ignorelist.txt`.

================
Comment at: llvm/cmake/modules/HandleLLVMOptions.cmake:966
+      if (NOT CLANG_CL)
+        message(FATAL_ERROR "This sanitizer only supported in the clang-cl: Undefined")
+      endif()
----------------
Perhaps `supported by clang-cl`?

================
Comment at: llvm/utils/sanitizers/ubsan_ignorelist.txt:24
+src:*/ADT/SmallPtrSet.h
\ No newline at end of file

----------------
Should add newline to the end of the file for "UNIX" consumers.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151511/new/

https://reviews.llvm.org/D151511