[PATCH] D151932: Add dsymutil dwarf5 tests for darwin

Shubham Sandeep Rastogi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 6 10:08:14 PDT 2023


rastogishubham marked an inline comment as done.
rastogishubham added a comment.

In D151932#4390596 <https://reviews.llvm.org/D151932#4390596>, @fdeazeve wrote:

> Thanks for adding more tests!
>
> I have two high level questions:
>
> 1. Are the `standard_opcode_lengths` CHECKs relevant for what we are trying to test here?
> 2. Is the traditional approach for dsymutil tests to have a YAML object file? I see that the same directory has tests that assemble an object file from `.ll` files (by calling `llc`) and also tests that assembly an object file from assembly (`.s`) by calling `llvm-mc`. Both seem shorter / easier to follow, but I have never looked much into those tests.

@fdeazeve I doubt the standard opcode lengths vary too much, I just wanted to check to make sure that the whole line table header looks okay


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151932/new/

https://reviews.llvm.org/D151932



More information about the llvm-commits mailing list