[PATCH] D152103: [LLVM] Removes CMake work-arounds.

Mark de Wever via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 23:09:04 PDT 2023


Mordante planned changes to this revision.
Mordante added a comment.

In D152103#4397757 <https://reviews.llvm.org/D152103#4397757>, @h-vetinari wrote:

> Old CMake mentioned in llvm-owned files:
>
> - https://github.com/llvm/llvm-project/blob/main/llvm/cmake/modules/LLVMCheckLinkerFlag.cmake#L8
> - https://github.com/llvm/llvm-project/blob/main/llvm/cmake/modules/AddLLVM.cmake#L2199

I feel changing this is out of scope. I agree it would be nice to fix this, but I will not pursue it. Feel free to provide patches for these improvements.

> There's also a bunch in the docs (primarily https://github.com/llvm/llvm-project/blob/main/llvm/docs/CMakePrimer.rst, but also here <https://github.com/llvm/llvm-project/blob/main/llvm/docs/HowToBuildOnARM.rst> & here <https://github.com/llvm/llvm-project/blob/main/llvm/docs/GettingStartedVS.rst>) though that's probably more work.

Thanks I'll fix this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152103/new/

https://reviews.llvm.org/D152103



More information about the llvm-commits mailing list