[PATCH] D152103: [LLVM] Removes CMake work-arounds.

[H. Vetinari via Phabricator via llvm-commits]

h-vetinari added a comment.

Old CMake mentioned in llvm-{owned,related} files:

- https://github.com/llvm/llvm-project/blob/main/llvm/cmake/modules/LLVMCheckLinkerFlag.cmake#L8
- https://github.com/llvm/llvm-project/blob/main/cmake/Modules/CMakePolicy.cmake

There's also a bunch in the docs (primarily https://github.com/llvm/llvm-project/blob/main/llvm/docs/CMakePrimer.rst, but also here <https://github.com/llvm/llvm-project/blob/main/llvm/docs/HowToBuildOnARM.rst> & here <https://github.com/llvm/llvm-project/blob/main/llvm/docs/GettingStartedVS.rst>) though that's probably more work.



================
Comment at: llvm/CMakeLists.txt:101-113
 # Set default build type for cmake's try_compile module.
 # CMake 3.17 or newer sets CMAKE_DEFAULT_BUILD_TYPE to one of the
 # items from CMAKE_CONFIGURATION_TYPES. Logic below can be further
 # simplified once LLVM's minimum CMake version is updated to 3.17.
 if(CMAKE_DEFAULT_BUILD_TYPE)
   set(CMAKE_TRY_COMPILE_CONFIGURATION ${CMAKE_DEFAULT_BUILD_TYPE})
 else()
----------------
Marked as up for simplification if CMake >=3.17


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152103/new/

https://reviews.llvm.org/D152103