[PATCH] D151863: [x86][MC] Fix movdir64b addressing

[Akshay Khadse via Phabricator via llvm-commits]

akshaykhadse added inline comments.


================
Comment at: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp:1780
   // Otherwise, we set the base register to a non-zero value
-  // if we don't know the actual value at this time.  This is necessary to
+  // if we don't know the actual value at this time. This is necessary to
   // get the matching correct in some cases.
----------------
skan wrote:
> This logic was firstly added by 7ca135b25ff408fda31f3b01d5e9303054e8267f.
> 
> I am not sure whether it's out of date now. But if removing it can make your test pass and not introduce LIT regression,  removing should be a better fix. 
> 
> We shouldn't turn a logic we don't understand into another logic we don't understand, which would confuse later developers
Ok, let me change this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151863/new/

https://reviews.llvm.org/D151863