[llvm] b56c439 - [NFC][COFF] clang-format WinCOFFObjectWriter and MCWinCOFFObjectWriter
Haohai Wen via llvm-commits
llvm-commits at lists.llvm.org
Sun Jun 4 22:42:14 PDT 2023
Author: Haohai Wen
Date: 2023-06-05T13:42:01+08:00
New Revision: b56c439d7dc42ae7bcbe3e3c703aad5bd992f715
URL: https://github.com/llvm/llvm-project/commit/b56c439d7dc42ae7bcbe3e3c703aad5bd992f715
DIFF: https://github.com/llvm/llvm-project/commit/b56c439d7dc42ae7bcbe3e3c703aad5bd992f715.diff
LOG: [NFC][COFF] clang-format WinCOFFObjectWriter and MCWinCOFFObjectWriter
Reviewed By: skan
Differential Revision: https://reviews.llvm.org/D152119
Added:
Modified:
llvm/include/llvm/MC/MCWinCOFFObjectWriter.h
llvm/lib/MC/WinCOFFObjectWriter.cpp
Removed:
################################################################################
diff --git a/llvm/include/llvm/MC/MCWinCOFFObjectWriter.h b/llvm/include/llvm/MC/MCWinCOFFObjectWriter.h
index 3015efe7389e4..e471be6b549e5 100644
--- a/llvm/include/llvm/MC/MCWinCOFFObjectWriter.h
+++ b/llvm/include/llvm/MC/MCWinCOFFObjectWriter.h
@@ -20,37 +20,37 @@ class MCFixup;
class MCValue;
class raw_pwrite_stream;
- class MCWinCOFFObjectTargetWriter : public MCObjectTargetWriter {
- virtual void anchor();
-
- const unsigned Machine;
-
- protected:
- MCWinCOFFObjectTargetWriter(unsigned Machine_);
-
- public:
- virtual ~MCWinCOFFObjectTargetWriter() = default;
-
- Triple::ObjectFormatType getFormat() const override { return Triple::COFF; }
- static bool classof(const MCObjectTargetWriter *W) {
- return W->getFormat() == Triple::COFF;
- }
-
- unsigned getMachine() const { return Machine; }
- virtual unsigned getRelocType(MCContext &Ctx, const MCValue &Target,
- const MCFixup &Fixup, bool IsCrossSection,
- const MCAsmBackend &MAB) const = 0;
- virtual bool recordRelocation(const MCFixup &) const { return true; }
- };
-
- /// Construct a new Win COFF writer instance.
- ///
- /// \param MOTW - The target specific WinCOFF writer subclass.
- /// \param OS - The stream to write to.
- /// \returns The constructed object writer.
- std::unique_ptr<MCObjectWriter>
- createWinCOFFObjectWriter(std::unique_ptr<MCWinCOFFObjectTargetWriter> MOTW,
- raw_pwrite_stream &OS);
+class MCWinCOFFObjectTargetWriter : public MCObjectTargetWriter {
+ virtual void anchor();
+
+ const unsigned Machine;
+
+protected:
+ MCWinCOFFObjectTargetWriter(unsigned Machine_);
+
+public:
+ virtual ~MCWinCOFFObjectTargetWriter() = default;
+
+ Triple::ObjectFormatType getFormat() const override { return Triple::COFF; }
+ static bool classof(const MCObjectTargetWriter *W) {
+ return W->getFormat() == Triple::COFF;
+ }
+
+ unsigned getMachine() const { return Machine; }
+ virtual unsigned getRelocType(MCContext &Ctx, const MCValue &Target,
+ const MCFixup &Fixup, bool IsCrossSection,
+ const MCAsmBackend &MAB) const = 0;
+ virtual bool recordRelocation(const MCFixup &) const { return true; }
+};
+
+/// Construct a new Win COFF writer instance.
+///
+/// \param MOTW - The target specific WinCOFF writer subclass.
+/// \param OS - The stream to write to.
+/// \returns The constructed object writer.
+std::unique_ptr<MCObjectWriter>
+createWinCOFFObjectWriter(std::unique_ptr<MCWinCOFFObjectTargetWriter> MOTW,
+ raw_pwrite_stream &OS);
} // end namespace llvm
#endif // LLVM_MC_MCWINCOFFOBJECTWRITER_H
diff --git a/llvm/lib/MC/WinCOFFObjectWriter.cpp b/llvm/lib/MC/WinCOFFObjectWriter.cpp
index 11a98aab7375c..65adce2a633b5 100644
--- a/llvm/lib/MC/WinCOFFObjectWriter.cpp
+++ b/llvm/lib/MC/WinCOFFObjectWriter.cpp
@@ -59,11 +59,7 @@ constexpr int OffsetLabelIntervalBits = 20;
using name = SmallString<COFF::NameSize>;
-enum AuxiliaryType {
- ATWeakExternal,
- ATFile,
- ATSectionDefinition
-};
+enum AuxiliaryType { ATWeakExternal, ATFile, ATSectionDefinition };
struct AuxSymbol {
AuxiliaryType AuxType;
@@ -434,8 +430,8 @@ void WinCOFFObjectWriter::DefineSymbol(const MCSymbol &MCSym,
// If no storage class was specified in the streamer, define it here.
if (Local->Data.StorageClass == COFF::IMAGE_SYM_CLASS_NULL) {
- bool IsExternal = MCSym.isExternal() ||
- (!MCSym.getFragment() && !MCSym.isVariable());
+ bool IsExternal =
+ MCSym.isExternal() || (!MCSym.getFragment() && !MCSym.isVariable());
Local->Data.StorageClass = IsExternal ? COFF::IMAGE_SYM_CLASS_EXTERNAL
: COFF::IMAGE_SYM_CLASS_STATIC;
@@ -523,7 +519,7 @@ void WinCOFFObjectWriter::WriteAuxiliarySymbols(
break;
case ATFile:
W.OS.write(reinterpret_cast<const char *>(&i.Aux),
- UseBigObj ? COFF::Symbol32Size : COFF::Symbol16Size);
+ UseBigObj ? COFF::Symbol32Size : COFF::Symbol16Size);
break;
case ATSectionDefinition:
W.write<uint32_t>(i.Aux.SectionDefinition.Length);
@@ -533,7 +529,8 @@ void WinCOFFObjectWriter::WriteAuxiliarySymbols(
W.write<uint16_t>(static_cast<int16_t>(i.Aux.SectionDefinition.Number));
W.OS << char(i.Aux.SectionDefinition.Selection);
W.OS.write_zeros(sizeof(i.Aux.SectionDefinition.unused));
- W.write<uint16_t>(static_cast<int16_t>(i.Aux.SectionDefinition.Number >> 16));
+ W.write<uint16_t>(
+ static_cast<int16_t>(i.Aux.SectionDefinition.Number >> 16));
if (UseBigObj)
W.OS.write_zeros(COFF::Symbol32Size - COFF::Symbol16Size);
break;
@@ -699,15 +696,15 @@ void WinCOFFObjectWriter::recordRelocation(MCAssembler &Asm,
const MCSymbol &A = Target.getSymA()->getSymbol();
if (!A.isRegistered()) {
- Asm.getContext().reportError(Fixup.getLoc(),
- Twine("symbol '") + A.getName() +
- "' can not be undefined");
+ Asm.getContext().reportError(Fixup.getLoc(), Twine("symbol '") +
+ A.getName() +
+ "' can not be undefined");
return;
}
if (A.isTemporary() && A.isUndefined()) {
- Asm.getContext().reportError(Fixup.getLoc(),
- Twine("assembler label '") + A.getName() +
- "' can not be undefined");
+ Asm.getContext().reportError(Fixup.getLoc(), Twine("assembler label '") +
+ A.getName() +
+ "' can not be undefined");
return;
}
More information about the llvm-commits
mailing list