[PATCH] D146774: [AMDGPU][IGLP]: Add rules to SchedGroups

[Austin Kerbow via Phabricator via llvm-commits]

kerbowa added a comment.

Looks good thanks. I think adding some more structure around rules i.e. having things like rule types for common patterns could be a good addition in the future. Having these open-ended functions could lead to a lot of repeat code and disorganization if the number of strategies gets higher. Having base rules like isSuccessorWithProperty for example.



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUIGroupLP.cpp:926
+
+  SmallVector<InstructionRuleType, 4> DemoRules;
+  DemoRules.push_back(Rule1);
----------------
Can you add an addrule function in SchedGroup so that we don't need to do this extra copying?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D146774/new/

https://reviews.llvm.org/D146774