[PATCH] D151943: [InstCombine] Propagate some func/arg/ret attributes from caller to callsite

Sun Jun 4 13:06:35 PDT 2023

goldstein.w.n added a comment.

In D151943#4394297 <https://reviews.llvm.org/D151943#4394297>, @fhahn wrote:

> In D151943#4394220 <https://reviews.llvm.org/D151943#4394220>, @goldstein.w.n wrote:
>
>> In D151943#4394217 <https://reviews.llvm.org/D151943#4394217>, @nikic wrote:
>>
>>> In D151943#4394139 <https://reviews.llvm.org/D151943#4394139>, @goldstein.w.n wrote:
>>>
>>>> At the moment FunctionAttrs doesn't do any callsite modifications, only the functions themselves. If you think it fits, however, I'd be okay extending FunctionAttrs. Same for nocapture patch? Also should I wait on D152081 <https://reviews.llvm.org/D152081> or since thats too the attributor still makes sense to try and get something into FunctionAttrs?
>>>
>>> I think it's pretty unlikely that the Attributor will be enabled by default anytime soon, so I wouldn't wait on that. I expect a substantial investment in improving Attributor compile-times will be needed to make this even remotely viable.
>
> Yeah, unfortunately I was hoping for more encouraging compile-time data.

I see. Well I'm working on porting to helper that can be used in inliner/functionattrs (and I guess attributor too). Ill test compile time of both and see what makes sense.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151943/new/

https://reviews.llvm.org/D151943