[PATCH] D152064: CI: run "apt update" once per job before installing packages

Charles the Thobe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 4 04:10:15 PDT 2023


charlesthobe added inline comments.


================
Comment at: .github/workflows/release-binaries.yml:65
     needs: prepare
     runs-on: ${{ matrix.target.runs-on }}
     strategy:
----------------
Comment on the original behavior:
The matrix only has one element in the "runs-on" array which is "ubuntu-22.04-8x32" so a check for the runner OS or the value of the array element isn't needed, also the check is absent from other checks, if in the future this matrix array is going to be expanded then checks are gonna have to be added.


================
Comment at: .github/workflows/release-binaries.yml:85
     - name: Install Brew build dependencies
       if: matrix.target.brew-build-deps != ''
       run: brew install ${{ matrix.target.brew-build-deps }}
----------------
Comment on the original behavior:
This condition is never met.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152064/new/

https://reviews.llvm.org/D152064



More information about the llvm-commits mailing list