[PATCH] D150230: [GlobalISel] Implement some binary reassociations, G_ADD for now

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 4 04:03:11 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:13441
+                                           Register N0, Register N1) const {
+  return false; // FIXME: handle regbanks
+}
----------------
Go with return true and leave the fixme? The diff was overall better I think 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150230/new/

https://reviews.llvm.org/D150230



More information about the llvm-commits mailing list