[PATCH] D152082: [ValueTracking] getUnderlyingObject() look through phi.

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 4 00:13:02 PDT 2023


nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.

If you upload the base revision I can check, but I'm pretty confident that this is not viable from a compile-time perspective. getUnderlyingObject() is very performance critical, and we rely on the fact that this operation is "essentially free". We have a separate getUnderlyingObjects() function that can recurse though selects and phis.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152082/new/

https://reviews.llvm.org/D152082



More information about the llvm-commits mailing list