[PATCH] D152081: [Attributor] Add lightweight version for attribute deduction only. (WIP)

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1297
+  else
+    MPM.addPass(ReversePostOrderFunctionAttrsPass());
 
----------------
nikic wrote:
> Note that what you're replacing here is the late module RPO inference pass, which only infers `norecurse`. All other attributes are inferred by the CGSCC pass. Doing the inference here is too late (at least for non-LTO scenarios), we need this to happen as part of the CGSCC pipeline.
We also want to make sure we do callsite inference before inlining, otherwise a lot of the attribute information will be lost.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152081/new/

https://reviews.llvm.org/D152081