[PATCH] D150264: [libcxx] Add strict weak ordering checks to sorting algorithms
Mark de Wever via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 3 07:16:14 PDT 2023
Mordante added a comment.
In D150264#4380575 <https://reviews.llvm.org/D150264#4380575>, @danlark wrote:
> I don't have commit rights, can you help me submit the change?
>
> Danila Kutenin
> kutdanila at yandex.ru
I tried to land this patch on your behalf, but there are some merge conflicts. Can you rebase the patch on main?
================
Comment at: libcxx/test/libcxx/private_headers.verify.cpp:345
#include <__debug_utils/randomize_range.h> // expected-error@*:* {{use of private header from outside its module: '__debug_utils/randomize_range.h'}}
+#include <__debug_utils/strict_weak_ordering_check.h> // expected-error@*:* {{use of private header from outside its module: '__debug_utils/strict_weak_ordering_check.h'}}
#include <__exception/exception.h> // expected-error@*:* {{use of private header from outside its module: '__exception/exception.h'}}
----------------
This file is removed upstream, can you revert this hunk before rebasing?
================
Comment at: llvm/utils/gn/secondary/libcxx/include/BUILD.gn:381
"__debug_utils/randomize_range.h",
+ "__debug_utils/strict_weak_ordering_check.h",
"__exception/exception.h",
----------------
FYI this is done automatically.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150264/new/
https://reviews.llvm.org/D150264
More information about the llvm-commits
mailing list