[PATCH] D151932: Add dsymutil dwarf5 tests for darwin

[Alexey Lapshin via Phabricator via llvm-commits]

avl added inline comments.


================
Comment at: llvm/test/tools/dsymutil/ARM/dwarf5-darwin.test:1
+RUN: rm -rf %t.dir && mkdir -p %t.dir
+RUN: yaml2obj %p/../Inputs/dwarf5-darwin.yaml -o %t.dir/dwarf5-darwin.o
----------------
bulbazord wrote:
> avl wrote:
> > probably, it should have
> > ```
> > # REQUIRES: system-darwin
> > ```
> > ?
> My understanding is that shouldn't be needed. You can run most dsymutil tests on non-darwin systems.
The test is named as if it has something Darwin specific. If it is not then, probably, it would be better to name it without mentioning Darwin. Also, it would be good if the test would describe itself in the very beginning. Something like:


```
## This test checks that simple MachO binary contains consistent DWARFv5 info.
```

or 


```
## This test checks that dsymutil generates the correct headers and sections for a MachO binary linked with one object file containing DWARFv4 and the other containing DWARFv5.

```


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151932/new/

https://reviews.llvm.org/D151932