[PATCH] D151965: [ThinLTO] Fix internalization decisions for weak/linkonce ODR

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In D151965#4391631 <https://reviews.llvm.org/D151965#4391631>, @steven_wu wrote:

>> The only way I can think of to test that is to use llvm-lto with --exported-symbol=, which preserves that symbol via ThinLTOCodeGenerator::preserveSymbol.
>
> So the new API users don't use the exported symbol function? Then current test case looks fine to me.

Right. The new LTO expects the linker (or llvm-lto2) to give the exact resolution of every non-internal symbol defined or referenced in each module (i.e. whether prevailing, exported, etc).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151965/new/

https://reviews.llvm.org/D151965