[PATCH] D151824: [lld-macho]Fixed bug folding LSDA incorrectly

Fri Jun 2 09:05:47 PDT 2023

smeenai added a comment.

I might not be understanding this diff correctly, but it seems like the code change just ensures that referent section canonicalization occurs for the UNSIGNED relocation following a SUBTRACTOR relocation. Is that the gist of the issue, and if so, could you update the summary to explain where such relocations are used in the unwind data and why it fixes the bug?

The test case is missing any assertions.

================
Comment at: lld/test/MachO/fold-dwarf-lsda.s:4
+## Use an old version to ensure we do *not* have any compact-unwind.                
+# RUN: llvm-mc  -filetype=obj -triple=x86_64-apple-macos %s -o %t.o
+# RUN: %lld -lSystem -lc++ --icf=all -arch x86_64 -arch x86_64 -platform_version macos 11.0 11.0 %t.o -o %t.out
----------------
Maybe use an explicit version in the triple which we know to not have compact unwind?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151824/new/

https://reviews.llvm.org/D151824